On Tue, Feb 14, 2012 at 10:44 AM, Rajendra Nayak <rnayak@xxxxxx> wrote: > On Saturday 11 February 2012 12:48 AM, Tony Lindgren wrote: >> >> * Santosh Shilimkar<santosh.shilimkar@xxxxxx> [120202 05:33]: >>> >>> > From: Rajendra Nayak<rnayak@xxxxxx> >>> > >>> > hwmod setup already does a reset and sets the OCP sysconfig >>> > registers appropriately. Avoid doing a reset again and overriding >>> > the OCP sysconfig settings in the system timer init code. > >> >> >> If we want this queued as a fix, it should also describe what >> actually breaks? Timer? PM? > > > It only fixes the redundant reset and overriding the smartidle-wakeup > OCP setting (done by hwmod) with the smartidle in the driver. > Doing this doesn't really break anything as yet in mainline, but will > cause timer wakeup issues once OFF mode is in place for OMAP4. On OMAP5 > however this was causing more issues as the softreset bit position is > different than on OMAP2/3/4. > So it should be ok to queue this in for 3.4 considering neither OMAP4 > OFF, not OMAP5 support is in mainline yet. > I second Rajendra's comment. Regards Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
