On Wed, Feb 08, 2012 at 04:40:27PM -0800, Tony Lindgren wrote:
> * Kevin Hilman <khilman@xxxxxx> [120208 15:49]:
> > Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> writes:
> >
> > > On Wed, Feb 08, 2012 at 04:09:48PM -0800, Kevin Hilman wrote:
> > >> Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> writes:
> > >> > Does it fix the other issues I mention in the commit log as well?
> > >>
> > >> Like your patches 1 & 5, my series fixes the oops and also makes the
> > >> error strings simple, non-wrapping ones.
> > >>
> > >> The one thing it doesn't fix is the spelling typo you fixed in the
> > >> comment, but IMO we can leave that out for -rc.
> > >
> > > OK, but it would be much better for that simple fix to go with another
> > > simple patch. On its own it doesn't make sense as a commit.
> >
> > Agreed. We'll have some other VC/VP cleanup for v3.4, and I'll add this
> > into that cleanup.
>
> Eek, looking at it, I'd rather stay away from this formatting patch
> for -rc series because the flaming potential causes me rash!
>
> Russell's patch 5 has way better description for the -rc series.
>
> So I now suggest that Russell drops patch 1 and updates patch 5 to
> cover both vp.c and vc.c.
I'm not sure what you want me to update in patch 5. vp.c already
contains:
if (!voltdm->pmic) {
pr_err("%s: No PMIC info for vdd_%s\n", __func__, voltdm->name);
return;
}
which is where I got the idea for the message I put into vc.c.
> d269914ece0498f31603ecd85ed3d7a586b3cbcd ARM: OMAP2+: PM: only register TWL with voltage layer when device is present
> af9a2ed9667b49e7e125eac526d8f655183ce53e ARM: OMAP2+: voltage: add check for missing PMIC info in VP init
I'd like at least the first in my tree too, otherwise my stuff becomes
untestable without patch 1. What's the second doing?
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
