> -----Original Message----- > From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of Henry Chan > Sent: Tuesday, February 07, 2012 11:27 PM > To: linux-omap@xxxxxxxxxxxxxxx > Subject: Incorrect Register Offsets in OMAP Mailbox > > Hi, > > Looks like the register offsets are incorrect in the OMAP mailbox code > (arch/arm/mach-omap2/mailbox.c) for the OMAP4_MAILBOX_IRQ* macros. The > discrepancy is with p.224 of TI document SPRUGX9 and p3891 of SWPU231K. > Patch attached. > > My hardware hasn't come in yet, so I would appreciate it if anyone can > share their experience using this code. > Yes, this change is required. Other than this fix the code is fine IMO. I guess the address calculation macros can be simplified to match with the terminology used in the TRM. I'll submit a patch for that once I manage to get some time for doing it right. Regards, Vaibhav -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
