* Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> [120208 14:19]: > On Wed, Feb 08, 2012 at 10:36:07AM -0800, Tony Lindgren wrote: > > * Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> [120208 08:05]: > > > When a PMIC is not found, this driver is unable to obtain its > > > 'vdds_dsi_reg' regulator. Even through its initialization function > > > fails, other code still calls its enable function, which fails to > > > check whether it has this regulator before asking for it to be enabled. > > > > > > This fixes the oops, however a better fix would be to sort out the > > > upper layers to prevent them calling into a module which failed to > > > initialize. > > > > > > Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx> > > > > Tomi can look into fixing this properly for v3.4: > > > > Acked-by: Tony Lindgren <tony@xxxxxxxxxxx> > > No, it's a thing for v3.3, because you can still get this oops. > > I expect _most_ of these patches will go into v3.3, and anything with > 'fix' or 'oops' in especially I want to see in v3.3. I acked your patch for -rc. Then Tomi can work on the "better fix part" you mention above for v3.4 and that's what I meant by my comment above. Or is there something else that needs fixing for the -rc series there? Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
