On Wed, Feb 8, 2012 at 4:34 PM, Luciano Coelho <coelho@xxxxxx> wrote: > On Wed, 2012-02-08 at 12:59 +0200, Felipe Balbi wrote: >> On Wed, Feb 08, 2012 at 12:56:52PM +0200, Luciano Coelho wrote: >> > Since commit 6145197be6cc0583fa1a2f4ec1079d366137061e, building >> >> we generally like to see the commit subject here too. And adding the >> abbreviated commit instead of the full sha1, wouldn't hurt either ;-) > > Ok, different practices. :) However there was already a discurssion. Anyways thanks for the patch. http://permalink.gmane.org/gmane.linux.ports.arm.omap/69796 > > I'll send v2. I think there was already a fix for this. http://www.spinics.net/lists/linux-omap/msg63151.html Anyways thanks for the patch. > > >> > i2c_omap.c breaks if CONFIG_OF is not set: >> > >> > drivers/i2c/busses/i2c-omap.c: In function 'omap_i2c_probe': >> > drivers/i2c/busses/i2c-omap.c:1021: error: 'omap_i2c_of_match' undeclared (first use in this function) >> > drivers/i2c/busses/i2c-omap.c:1021: error: (Each undeclared identifier is reported only once >> > drivers/i2c/busses/i2c-omap.c:1021: error: for each function it appears in.) >> > >> > This is because the definition of omap_i2c_of_match is #ifdef'd on >> > CONFIG_OF, but the usage of it is not. >> > >> > Since the places where omap_ic2_of_match are prepared to get NULL >> > pointers if CONFIG_OF is not defined, we can simply define it to NULL. >> > >> > Cc: Benoit Cousson <b-cousson@xxxxxx> >> > Signed-off-by: Luciano Coelho <coelho@xxxxxx> >> >> after fixing the commit log, you can add: >> >> Reviewed-by: Felipe Balbi <balbi@xxxxxx> >> >> if you want. > > Thanks for your quick review! > > -- > Cheers, > Luca. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-i2c" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
