On Fri, Feb 3, 2012 at 12:10 AM, Kevin Hilman <khilman@xxxxxx> wrote: > Santosh Shilimkar <santosh.shilimkar@xxxxxx> writes: > >> From: Rajendra Nayak <rnayak@xxxxxx> >> >> hwmod setup already does a reset and sets the OCP sysconfig >> registers appropriately. Avoid doing a reset again and overriding >> the OCP sysconfig settings in the system timer init code. > > That is true for OMAP4, but have you verified if this is indeed a > duplicate reset on OMAP2/3? > Yes. It is duplicate for OMAP2 and OMAP3 devices as well. Actually this should have been fixed when the driver was hwmod converted but some how got missed. We noticed an issue on OMAP5, when timer interrupts stopped firing when always on clock domain was allowed to idle. This was because this reset was clearing the correctly set sysc value by hwmod. The patch is also tested on ZOOM3 ( OMAP3630) and OMAP2430SDP. Regards Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html