On Tue, 31 Jan 2012, Kevin Hilman wrote: > Kevin Hilman <khilman@xxxxxx> writes: > > > Paul Walmsley <paul@xxxxxxxxx> writes: > > > >> Remove some superfluous calls to pwrdm_clear_all_prev_pwrst(). > >> pwrdm_pre_transition(), which appears a few lines after these calls, > >> invokes pwrdm_clear_all_prev_pwrst() on each powerdomain -- there's no > >> need to do it twice. > > > > It looks like these two for OMAP4 are surpurfluous since the immediately > > follow a call to pwrdm_pre_transition() as well. > > > > Santosh/Rajendra, please confirm/ack. > > So after the discussion, do you want to fold this into the original > patch, or do you want a separate patch? Your changes make sense to me. I am fine with you adding them into the original patch and adding some credit for you into the commit message. Or you can create a separate patch. N.B., I haven't looked at this file before. There are a few other things that don't look right that hopefully someone can take the initiative to fix. For example, those calls to mpuss_clear_prev_logic_pwrst() and cpu_clear_prev_logic_pwrst() should be removed as well. That should be done by pwrdm_clear_all_prev_pwrst() in mach-omap2/powerdomain44xx.c. Currently it's not, so that needs to be patched. Also all of the open-coded powerdomain register accesses in omap-mpuss-lowpower.c should be removed - those should all go through pwrdm_*() functions... - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
