On Tue, Jan 31, 2012 at 12:09:17PM -0600, Omar Ramirez Luna wrote: > On Tue, Jan 31, 2012 at 2:17 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > On Mon, Jan 30, 2012 at 07:20:17PM -0600, Omar Ramirez Luna wrote: > >> There are two members of pr_ctxt allocated during bridge_open that > >> are never freed resulting in memory leaks, these are stream_id and > >> node_id, they are now freed on release of the handle (bridge_release) > >> right before freeing pr_ctxt. > >> > >> Error path for bridge_open was also fixed since the same variables > >> could result in memory leaking due to missing handling of failure > >> scenarios. While at it, the indentation changes were introduced to > >> avoid interleaved goto statements inside big if blocks. > >> > > > > You mentioned in the cover letter email that you wanted these to go > > into stable. I don't think that is needed here. These are tiny > > leaks that we aren't going to hit in real life. > > They are hit each time an app opens a handle e.g.: > > gst-launch <something> > > So after 'X' number of playbacks there won't be memory left. > Ah. That sounds worth while then. regards, dan carpenter
Attachment:
signature.asc
Description: Digital signature
