> From: Paul Walmsley <paul@xxxxxxxxx> > To: Joakim Tjernlund <joakim.tjernlund@xxxxxxxxxxxx> > Cc: "linux-mtd@xxxxxxxxxxxxxxxxxxx" <linux-mtd@xxxxxxxxxxxxxxxxxxx>, Richard Purdie <rpurdie@xxxxxxxxxxxxxx>, "linux-omap@xxxxxxxxxxxxxxx" <linux-omap@xxxxxxxxxxxxxxx>, David Woodhouse <dwmw2@xxxxxxxxxxxxx>, Orjan Friberg <of@xxxxxxxxxxxx> > Date: 2012/01/26 18:00 > Subject: Re: CONFIG_PREEMPT and JFFS2 oops > Sent by: linux-mtd-bounces@xxxxxxxxxxxxxxxxxxx > > On Thu, 26 Jan 2012, Joakim Tjernlund wrote: > > > Still leeks: > > + best_slen = tdl; > > + best_buf = tmp_buf; > > + best = this; > > > > You just throw away best_buf here, don't you? > > You're right. It's even worse than that. best_buf will contain the data > from the last compressor used. And it will be prematurely freed. Here's > a fixed version. > > Time for breakfast. hmm, that memcpy is costly. Just swap tmp_buf and best_buf instead? Time to go home :) Jocke -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
