cc'ing linux-arm-kernel also (correct address this time) Hi some comments On Tue, 24 Jan 2012, Govindraj.R wrote: > From: "Govindraj.R" <govindraj.raja@xxxxxx> > > On omap3630 onwards uart wer reg has bit 7 > for tx wakeup enable. > > Without this bit set some uart sluggishness might be seen > while printing data on console, response is better when > enabling this bit. > Tested with Beagle XM (OMAP3630) > > Cc: Kevin Hilman <khilman@xxxxxx> > Cc: Paul Walmsley <paul@xxxxxxxxx> > Signed-off-by: Govindraj.R <govindraj.raja@xxxxxx> > --- > But on omap3430 the bit is not available. Well that's good news that it exists on 36xx+ at least. But please make a few changes. This shouldn't set this bit on UARTs that don't support it. It should only be set if a hwmod dev_attr flag was set to indicate the presence of this feature. Using a flag is also important since it will allow us to disable the workaround that we'll need for earlier OMAPs. Also, I assume that this does not fix the RX sluggishness due to the missing RX timeout wakeup? Also, this assignment should be using symbolic macros rather than raw bits. - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
