From: Colin Cross <ccross@xxxxxxxxxxx>
Running without smartreflex for any significant time (on the order
of seconds) is unsafe and can cause thermal runaway. Move
smartreflex suspend into suspend_noirq, so it happens as late as
possible. This prevents hangs that occur in a driver suspend
handler from running without smartreflex enabled. It will also
reduce power used during suspend and resume, as the voltages will
be lowered.
May also indirectly fix imprecise external aborts seen during
suspend, which could be caused by calls to sr_disable racing
from calls to dvfs_scale and omap_sr_disable.
Change-Id: Ia3c1e707bb1022ec102f506dc3ad48906e8890da
Signed-off-by: Colin Cross <ccross@xxxxxxxxxxx>
Signed-off-by: Jean Pihet <j-pihet@xxxxxx>
---
arch/arm/mach-omap2/smartreflex.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c
index fca8df69..95fd228 100644
--- a/arch/arm/mach-omap2/smartreflex.c
+++ b/arch/arm/mach-omap2/smartreflex.c
@@ -1095,7 +1095,10 @@ static int omap_sr_resume(struct device *dev)
return 0;
}
-static SIMPLE_DEV_PM_OPS(omap_sr_dev_pm_ops, omap_sr_suspend, omap_sr_resume);
+const static struct dev_pm_ops omap_sr_dev_pm_ops = {
+ .suspend_noirq = omap_sr_suspend,
+ .resume_noirq = omap_sr_resume,
+};
static struct platform_driver smartreflex_driver = {
.remove = omap_sr_remove,
--
1.7.5.4
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
