Hi Kevin, Thanks for the review. On Fri, Dec 2, 2011 at 4:45 PM, Kevin Hilman <khilman@xxxxxx> wrote: > Sergio Aguirre <saaguirre@xxxxxx> writes: > >> NOTE: This isn't the whole list of features that the >> ISS supports, but the only ones supported at the moment. >> >> Signed-off-by: Sergio Aguirre <saaguirre@xxxxxx> > > [...] > >> diff --git a/arch/arm/plat-omap/include/plat/omap44xx.h b/arch/arm/plat-omap/include/plat/omap44xx.h >> index ea2b8a6..31432aa 100644 >> --- a/arch/arm/plat-omap/include/plat/omap44xx.h >> +++ b/arch/arm/plat-omap/include/plat/omap44xx.h >> @@ -49,6 +49,15 @@ >> #define OMAP44XX_MAILBOX_BASE (L4_44XX_BASE + 0xF4000) >> #define OMAP44XX_HSUSB_OTG_BASE (L4_44XX_BASE + 0xAB000) >> >> +#define OMAP44XX_ISS_BASE 0x52000000 >> +#define OMAP44XX_ISS_TOP_BASE (OMAP44XX_ISS_BASE + 0x0) >> +#define OMAP44XX_ISS_CSI2_A_REGS1_BASE (OMAP44XX_ISS_BASE + 0x1000) >> +#define OMAP44XX_ISS_CAMERARX_CORE1_BASE (OMAP44XX_ISS_BASE + 0x1170) >> + >> +#define OMAP44XX_ISS_TOP_END (OMAP44XX_ISS_TOP_BASE + 256 - 1) >> +#define OMAP44XX_ISS_CSI2_A_REGS1_END (OMAP44XX_ISS_CSI2_A_REGS1_BASE + 368 - 1) >> +#define OMAP44XX_ISS_CAMERARX_CORE1_END (OMAP44XX_ISS_CAMERARX_CORE1_BASE + 32 - 1) >> + >> #define OMAP4_MMU1_BASE 0x55082000 >> #define OMAP4_MMU2_BASE 0x4A066000 > > Who are the users of thes address ranges? > > IMO, we shouldn't ned to add anymore based address definitions. These > should be done in the hwmod data, and drivers get base addresses using > the standard ways of getting resources (DT or platform_get_resource()) I see... I get your point now. Will remove them from this patch series then. Regards, Sergio > > Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
