On Thu, Dec 01, 2011 at 06:34:19, Hilman, Kevin wrote: > Vaibhav Hiremath <hvaibhav@xxxxxx> writes: > > > From: Afzal Mohammed <afzal@xxxxxx> > > > > This patch adds AM33XX power domain data, > > corresponding API's to access PRM module and > > PRM register offsets & bit fields. > > > > Signed-off-by: Rachna Patil <rachna@xxxxxx> > > Signed-off-by: Vaibhav Hiremath <hvaibhav@xxxxxx> > > Signed-off-by: Afzal Mohammed <afzal@xxxxxx> > > First some general comments: > > At first glance, it seems like there could be much more reuse with OMAP4 > code here. From what I see, AM33x has only one partition compared to > several on OMAP4, but that doesn't mean you couldn't reuse the OMAP4 > functions and just use a single partition. > > IOW, it seems to me that all the pwrdm_ops could be shared with OMAP4. > > From what I read (after an admittedly quick glance), the main thing you > need is a way to override the PRM offsets due to the fact that some > crazy person decided to make each instance different. If its any consolation, this has been fed back to the chip designers and is expected to be corrected for the next AM335x derivative. Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
