Re: [RFC PATCH v1 2/7] omap4: build fdif omap device from hwmod

["Aguirre, Sergio" <saaguirre@xxxxxx>]

Hi Ming,

Thanks for the patches.

On Fri, Dec 2, 2011 at 9:02 AM, Ming Lei <ming.lei@xxxxxxxxxxxxx> wrote:
> Signed-off-by: Ming Lei <ming.lei@xxxxxxxxxxxxx>
> ---
>  arch/arm/mach-omap2/devices.c |   33 +++++++++++++++++++++++++++++++++
>  1 files changed, 33 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
> index 1166bdc..a392af5 100644
> --- a/arch/arm/mach-omap2/devices.c
> +++ b/arch/arm/mach-omap2/devices.c
> @@ -728,6 +728,38 @@ void __init omap242x_init_mmc(struct omap_mmc_platform_data **mmc_data)
>
>  #endif
>
> +static struct platform_device* __init omap4_init_fdif(void)
> +{
> +       int id = -1;

You could remove this , as it is being used only once, and never changed.

> +       struct platform_device *pd;
> +       struct omap_hwmod *oh;
> +       const char *dev_name = "fdif";
> +
> +       oh = omap_hwmod_lookup("fdif");
> +       if (!oh) {
> +               pr_err("Could not look up fdif hwmod\n");
> +               return NULL;
> +       }
> +
> +       pd = omap_device_build(dev_name, id, oh, NULL, 0, NULL, 0, 0);

Just do:

pd = omap_device_build(dev_name, -1, oh, NULL, 0, NULL, 0, 0);

> +       WARN(IS_ERR(pd), "Can't build omap_device for %s.\n",
> +                               dev_name);
> +       return pd;
> +}
> +
> +static void __init omap_init_fdif(void)
> +{
> +       if (cpu_is_omap44xx()) {
> +               struct platform_device *pd;
> +
> +               pd = omap4_init_fdif();
> +               if (!pd)
> +                       return;
> +
> +               pm_runtime_enable(&pd->dev);
> +       }
> +}

IMHO, you could reduce 1 level of indentation here, like this:

static void __init omap_init_fdif(void)
{
	struct platform_device *pd;

	if (!cpu_is_omap44xx())
		return;

	pd = omap4_init_fdif();
	if (!pd)
		return;

	pm_runtime_enable(&pd->dev);
}

Regards,
Sergio

> +
>  /*-------------------------------------------------------------------------*/
>
>  #if defined(CONFIG_HDQ_MASTER_OMAP) || defined(CONFIG_HDQ_MASTER_OMAP_MODULE)
> @@ -808,6 +840,7 @@ static int __init omap2_init_devices(void)
>        omap_init_sham();
>        omap_init_aes();
>        omap_init_vout();
> +       omap_init_fdif();
>
>        return 0;
>  }
> --
> 1.7.5.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html