Hi Balaji, Thanks for the review. On Thu, Dec 1, 2011 at 9:58 AM, T Krishnamoorthy, Balaji <balajitk@xxxxxx> wrote: > On Thu, Dec 1, 2011 at 5:44 AM, Sergio Aguirre <saaguirre@xxxxxx> wrote: >> Signed-off-by: Sergio Aguirre <saaguirre@xxxxxx> >> --- >> drivers/mfd/twl-core.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c >> index bfbd660..e26b564 100644 >> --- a/drivers/mfd/twl-core.c >> +++ b/drivers/mfd/twl-core.c >> @@ -323,7 +323,7 @@ static struct twl_mapping twl6030_map[] = { >> { SUB_CHIP_ID0, TWL6030_BASEADD_ZERO }, >> { SUB_CHIP_ID1, TWL6030_BASEADD_ZERO }, >> >> - { SUB_CHIP_ID2, TWL6030_BASEADD_ZERO }, >> + { SUB_CHIP_ID1, TWL6030_BASEADD_AUX }, > > Instead you can use TWL6030_MODULE_ID1, with base address as > zero for all registers in auxiliaries register map. Ok. I'm actually thinking about this, and in the process on reviewing the need to access those registers. I should probably be using the regulator framework to control VAUX3 instead... Thanks for your inputs. Regards, Sergio > >> { SUB_CHIP_ID2, TWL6030_BASEADD_ZERO }, >> { SUB_CHIP_ID2, TWL6030_BASEADD_RSV }, >> { SUB_CHIP_ID2, TWL6030_BASEADD_RSV }, >> -- >> 1.7.7.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-omap" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html