> -----Original Message-----
> From: Hilman, Kevin
> Sent: Thursday, December 01, 2011 5:41 AM
> To: Hiremath, Vaibhav
> Cc: linux-omap@xxxxxxxxxxxxxxx; tony@xxxxxxxxxxx; paul@xxxxxxxxx; linux-
> arm-kernel@xxxxxxxxxxxxxxxxxxx; Cousson, Benoit; Mohammed, Afzal
> Subject: Re: [RFC PATCH 01/11] arm:omap:am33xx: Add voltage domain data
>
> Vaibhav Hiremath <hvaibhav@xxxxxx> writes:
>
> > From: Afzal Mohammed <afzal@xxxxxx>
> >
> > Currently dummy voltage domain data is being created
> > in order to succeed boot process.
> > Nothing has been done w.r.t actual hardware (voltage control).
> >
> > Signed-off-by: Afzal Mohammed <afzal@xxxxxx>
> > Signed-off-by: Vaibhav Hiremath <hvaibhav@xxxxxx>
>
> [...]
>
> > --- /dev/null
> > +++ b/arch/arm/mach-omap2/voltagedomains33xx_data.c
> > @@ -0,0 +1,37 @@
> > +/*
> > + * AM33XX voltage domain data
> > + *
> > + * Copyright (C) 2011 Texas Instruments, Inc.
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License version 2 as
> > + * published by the Free Software Foundation.
> > + */
> > +#include <linux/kernel.h>
> > +#include <linux/init.h>
> > +
> > +#include "voltage.h"
> > +
> > +static struct voltagedomain am33xx_voltdm_mpu = {
> > + .name = "mpu",
> > +};
>
> According to the TRM, there is no MPU voltage domain. Only CORE and RTC
> exist.
>
> However, looking at the data manual (SPRS717 Oct 2011), it seems that
> some packages have a separate VDD_MPU while others have a combined
> VDD_MPU and VDD_CORE.
>
> This should be clarified and documented in the changelog.
>
No, we do have VDD_MPU specifically documented in TRM (SPRUH73 - October2011).
The TRM is accessible at - http://www.ti.com/lit/ug/spruh73/spruh73.pdf
> > +static struct voltagedomain am33xx_voltdm_core = {
> > + .name = "core",
> > +};
> > +
> > +static struct voltagedomain am33xx_voltdm_rtc = {
> > + .name = "rtc",
> > +};
>
> Won't these basically empty voltage domains fail during voltage init?
> At a minimum, it seems they should have '.scaling = false' as well until
> voltage scalling is supported.
>
It won't fail, but I agree to your point that we should clearly specify
the state here.
I will add ".scaling = false" in next version.
Thanks a ton for the review.
Thanks,
Vaibhav
> > +static struct voltagedomain *voltagedomains_am33xx[] __initdata = {
> > + &am33xx_voltdm_mpu,
> > + &am33xx_voltdm_core,
> > + &am33xx_voltdm_rtc,
> > + NULL,
> > +};
> > +
> > +void __init am33xx_voltagedomains_init(void)
> > +{
> > + voltdm_init(voltagedomains_am33xx);
> > +}
>
> Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
