Re: [PATCHv4 02/15] omap3+: voltage: parameter segregation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Tero,

On Fri, Nov 25, 2011 at 4:49 PM, Tero Kristo <t-kristo@xxxxxx> wrote:
> -static void __init omap3_vfsm_init(struct voltagedomain *voltdm)
> +static void omap3_set_i2c_timings(struct voltagedomain *voltdm, int off_mode)
>  {
> +       unsigned long voltsetup1;
> +       u32 tgt_volt;
> +
> +       if (off_mode)
> +               tgt_volt = voltdm->vc_param->off;
> +       else
> +               tgt_volt = voltdm->vc_param->ret;
> +
> +       voltsetup1 = (voltdm->vc_param->on - tgt_volt) /
> +                       voltdm->pmic->slew_rate;
> +
> +       voltsetup1 = voltsetup1 * voltdm->sys_clk.rate / 8 / 1000000 + 1;
Minor: some () here would improve the code readability.

> +
> +       voltdm->rmw(voltdm->vfsm->voltsetup_mask,
> +               voltsetup1 << __ffs(voltdm->vfsm->voltsetup_mask),
> +               voltdm->vfsm->voltsetup_reg);
> +
>

Regards,
Jean
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux