On Sat, Nov 26, 2011 at 11:12:47AM +0000, Alan Cox wrote: > On Sat, 26 Nov 2011 12:31:44 +0800 > tom.leiming@xxxxxxxxx wrote: > > > From: Ming Lei <ming.lei@xxxxxxxxxxxxx> > > > > One face detection IP[1] is integared inside OMAP4 SoC, so > > introduce this driver to make face detection function work > > on OMAP4 SoC. > > > > This driver is platform independent, so in theory can > > be used to drive same IP module on other platforms. > > > > [1], ch9 of OMAP4 TRM > > > > Signed-off-by: Ming Lei <ming.lei@xxxxxxxxxxxxx> > > If you are submitting it then it ought to have your sign off too. This > looks hardly ready for submission however. > > > +config FDIF > > + tristate "Face Detection module" > > + help > > + The FDIF is a face detection module, which can be integrated into > > + SoCs to detect the location of human beings' face in one image. At > > + least now, TI OMAP4 has the module inside. > > So we have a completelt device specific API for what is becoming a more > general feature and on some hardware is tied to camera and the like. This > seems wrong > > IMHO this should be part of video4linux because that'll make the > integrated stuff work sanely and for your cases it still provided the > right kind of mmap and format interfaces you need. I agree, as-is, this isn't ok, sorry, please work with the v4l developers on this. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
