From: Paul Walmsley <paul@xxxxxxxxx>
If needed should be handled by an atomic notifier. Currently no
code needs this.
Signed-off-by: Paul Walmsley <paul@xxxxxxxxx>
Signed-off-by: Jean Pihet <j-pihet@xxxxxx>
---
arch/arm/mach-omap2/smartreflex.c | 8 +++++---
arch/arm/mach-omap2/smartreflex.h | 5 -----
2 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c
index 882f1d5..e57263a 100644
--- a/arch/arm/mach-omap2/smartreflex.c
+++ b/arch/arm/mach-omap2/smartreflex.c
@@ -110,8 +110,10 @@ static irqreturn_t sr_interrupt(int irq, void *data)
sr_write_reg(sr, IRQSTATUS, status);
}
- if (sr_class->notify)
- sr_class->notify(sr, status);
+ /*
+ * XXX If the class driver needs to be notified here, it should
+ * use an atomic notifier
+ */
return IRQ_HANDLED;
}
@@ -184,7 +186,7 @@ static int sr_late_init(struct smartreflex *sr)
struct resource *mem;
int ret = 0;
- if (sr_class->notify && sr_class->notify_flags && sr->irq) {
+ if (sr->irq) {
ret = request_irq(sr->irq, sr_interrupt, 0, sr->name,
(void *)sr);
if (ret)
diff --git a/arch/arm/mach-omap2/smartreflex.h b/arch/arm/mach-omap2/smartreflex.h
index 59fff8a..e0e8ee3 100644
--- a/arch/arm/mach-omap2/smartreflex.h
+++ b/arch/arm/mach-omap2/smartreflex.h
@@ -187,9 +187,6 @@ struct omap_sr_dev_attr {
* @enable: API to enable a particular class smaartreflex.
* @disable: API to disable a particular class smartreflex.
* @configure: API to configure a particular class smartreflex.
- * @notify: API to notify the class driver about an event in SR.
- * Not needed for class3.
- * @notify_flags: specify the events to be notified to the class driver
* @class_type: specify which smartreflex class.
* Can be used by the SR driver to take any class
* based decisions.
@@ -198,8 +195,6 @@ struct smartreflex_class_data {
int (*enable)(struct smartreflex *sr);
int (*disable)(struct smartreflex *sr, int is_volt_reset);
int (*configure)(struct smartreflex *sr);
- int (*notify)(struct smartreflex *sr, u32 status);
- u8 notify_flags;
u8 class_type;
};
--
1.7.5.4
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
