On Tue, 2011-11-22 at 18:37 +0530, K, Mythri P wrote: > >> + if (cpu_is_omap446x() || (omap_rev() > OMAP4430_REV_ES2_2)) > > > > If you compare omap_rev() you should also use cpu_is_omap at the > same > > time. In this case (cpu_is_omap443x() && omap_rev() > > > OMAP4430_REV_ES2_2). Otherwise the omap_rev check could match, say, > > omap3 or omap5 boards. > Hmmm I am not really sure if that is needed, I dont think omap3 or > omap5 boards would be named with rev "OMAP4430"_REV_ES2_2 ??? OMAP4430_REV_ES2_2 is just a symbolic name for a define for some number. There's no reason why OMAP3430_REV_ES1_0 wouldn't be defined to the same number. That said, looking at arch/arm/plat-omap/include/plat/cpu.h shows that the REV defines do include an OMAP class number, and so omap_rev() does return a number with cpu ID. So it seems you indeed do not need cpu_is_omap443x() there. Tomi
Attachment:
signature.asc
Description: This is a digitally signed message part
