"Premi, Sanjeev" <premi@xxxxxx> writes: > > >> -----Original Message----- >> From: Hilman, Kevin >> Sent: Friday, November 11, 2011 12:04 AM >> To: Premi, Sanjeev >> Cc: linux-omap@xxxxxxxxxxxxxxx; >> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Koyamangalath, Abhilash >> Subject: Re: [PATCH] ARM: OMAP: PM: only register TWL with >> voltage layer when device is present >> >> "Premi, Sanjeev" <premi@xxxxxx> writes: >> >> >> Current code registers voltage layer details for TWL PMIC >> even when a >> >> TWL has not been registered. Fix this to only register >> the TWL with >> >> voltage layer when the TWL PMIC is initialized by board-level code. >> >> >> >> Signed-off-by: Kevin Hilman <khilman@xxxxxx> >> >> [...] >> >> > I have been out-of-loop from PM for some time. So my query may be >> > redundant: >> > >> > 1) What happens when different PMIC (not TWL series) is registered >> > for AM35x? e.g. TPS65023 >> > http://www.spinics.net/lists/linux-omap/msg48630.html >> > >> > 2) Wouldn't we still fall back into omap3_twl_init()? >> >> I'm not sure I follow the question. >> >> If you're not using a TWL PMIC (or similar derivative) then >> omap*_twl_init() should not be called. >> >> If you are using a TWL PMIC, then no, the omap*_twl_init functions >> should not be called. > > When I read this function (in the patch), if pmic_i2c_board_info.irq > is non-zero, omap3_twl_init() and omap4_twl_init() are called. > > So my question was, for the case when PMIC is not TWL family. Then, > is checking ".irq" sufficient to prevent the execution of twl specific > functions. If PMIC is not TWL family, then I don't expect any functions in twl_common.c to be called. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
