> -----Original Message----- > From: Hilman, Kevin > Sent: Tuesday, November 08, 2011 1:15 AM > To: Hiremath, Vaibhav > Cc: linux-omap@xxxxxxxxxxxxxxx; tony@xxxxxxxxxxx > Subject: Re: [PATCH] arm:omap:serial:cleanup: use module rev instead of > cpu_is_xxxx > > Vaibhav Hiremath <hvaibhav@xxxxxx> writes: > > > For OMAP3 uarts (module rev >= 0x52) and all successor devices > > (omap4, TI81xx, AM33xx, etc...) empty fifo read errata is applicable, > > so we can get rid of cpu_is_xxxx check and simply check for module rev > here. > > > > Signed-off-by: Vaibhav Hiremath <hvaibhav@xxxxxx> > > --- > > NOTE: This patch has been tested on OMAP3EVM, and I expect to work on > all OMAP3 > > family of devices (including TI816x, TI814x, AM335x, etc...). > > but I am quite not sure about OMAP2 device, can anybody comment/test? > > Leaving OMAP2 as it is should be fine. > > There is a major UART cleanup in progress from Govindraj. I suggest you > rework this patch on top of his series from 10/18: > > [PATCH v7 00/21] OMAP2+: UART: Runtime adaptation + cleanup > > although it still has a few changes to go through before being ready to > merge. > Kevin, Sorry, I missed to update on this. We do not need this patch anymore. With latest cleanup series from Govindraj, it is already taken care. Please read below commit description - -------------From Govindraj's commit (405b5009)------------ Serial_in and serial_out override for 8250 serial driver is also removed. Empty fifo read fix is already taken care with omap-serial driver with data ready bit check from LSR reg before reading RX fifo. Also waiting for THRE(transmit hold reg empty) is done with wait_for_xmitr in omap-serial driver. Thanks, Vaibhav > Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
