2011/11/16 Joe Perches <joe@xxxxxxxxxxx>: > On Wed, 2011-11-16 at 10:55 +0900, NamJae Jeon wrote: >> 2011/11/16 Joe Perches <joe@xxxxxxxxxxx>: >> > On Wed, 2011-11-16 at 10:48 +0900, NamJae Jeon wrote: >> > >> > [123K of untrimmed reply] >> > >> > If you wrote something, I didn't find it. >> > >> >> > - dev_info(&pdev->dev, "DW MMC controller at irq %d, " >> > - "%d bit host data width, " >> > - "%u deep fifo\n", >> > + dev_info(&pdev->dev, >> > + "DW MMC controller at irq %d, %d bit host data width, %u deep fifo\n", >> > irq, width, fifo_size); >> >> I think that tab is needed this "DW MMC controller at irq ...." ? > > Argument alignment isn't always the right thing. > > Very long formats should not necessarily be aligned > at the open parenthesis. It helps to determine > when the format string or the dmesg output line length > is too long. Okay~ I understand clearly. Thanks. > Coalesce formats. > Align arguments. > Add pr_fmt, remove prefixes from format strings. > Neaten DBG uses, rearrange argument order. > > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx> Reviewed-by: NamJae Jeon <linkinjeon@xxxxxxxxx> > > > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
