Hi Tony, On Fri, Nov 11, 2011 at 10:52 PM, Tony Lindgren <tony@xxxxxxxxxxx> wrote: > * mythripk@xxxxxx <mythripk@xxxxxx> [111111 04:41]: >> From: Mythri P K <mythripk@xxxxxx> >> >> Disables the internal pull resistor for SDA and SCL enabled by >> default as there are expernal pull up's in 4460 and 4430 ES2.3, >> It is done to avoid the EDID read failure. >> >> Signed-off-by: Ricardo Salveti de Araujo <ricardo.salveti@xxxxxxxxxx> >> Signed-off-by: Mythri P K <mythripk@xxxxxx> >> --- >> arch/arm/mach-omap2/board-4430sdp.c | 12 +++++++++++- >> arch/arm/mach-omap2/board-omap4panda.c | 13 ++++++++++++- >> arch/arm/mach-omap2/display.c | 17 ++++++++++++++--- >> include/video/omapdss.h | 2 +- >> 4 files changed, 38 insertions(+), 6 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-omap2/board-4430sdp.c >> index 4a519a3..91d3742 100644 >> --- a/arch/arm/mach-omap2/board-4430sdp.c >> +++ b/arch/arm/mach-omap2/board-4430sdp.c >> @@ -826,7 +826,17 @@ static void omap_4430sdp_display_init(void) >> sdp4430_lcd_init(); >> sdp4430_picodlp_init(); >> omap_display_init(&sdp4430_dss_data); >> - omap_hdmi_enable_pads(); >> + /* >> + * CONTROL_I2C_1: HDMI_DDC_SDA_PULLUPRESX (bit 28) and >> + * HDMI_DDC_SCL_PULLUPRESX (bit 24) are set to disable >> + * internal pull up resistor - This is a change needed in >> + * OMAP4460 and OMAP4430 ES2.3 as the external pull up >> + * are present. This is needed to avoid EDID read failure. >> + */ >> + if (cpu_is_omap446x() || (omap_rev() > OMAP4430_REV_ES2_2)) >> + omap_hdmi_enable_pads(1); >> + else >> + omap_hdmi_enable_pads(0); >> } > > If you now have omap_hdmi_init(), then you can just pass it board > specific flags like OMAP_HDMI_EXTERNAL_PULL. The generic init function > will make it easier to move things over to DT also. > Thanks, sure will take care of this. Thanks and regards, Mythri. > Regards, > > Tony > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
