Re: [PATCH] OMAP2+: Fix Compilation error on current mainline

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 8, 2011 at 4:24 PM, Santosh Shilimkar
<santosh.shilimkar@xxxxxx> wrote:
> On Tuesday 08 November 2011 04:16 PM, Cousson, Benoit wrote:
>> Hi Govind,
>>
>> On 11/8/2011 7:28 AM, Govindraj.R wrote:
>>> Patch to fix below compilation error on latest mainline commit
>>> b32fc0a0629bf5894b35f33554c118aacfd0d1e2 with omap2plus_defconfig.
>>>
>>> arch/arm/mach-omap2/omap_l3_noc.c:250: error: 'THIS_MODULE' undeclared
>>> here (not in a function)
>>> make[1]: *** [arch/arm/mach-omap2/omap_l3_noc.o] Error 1
>>>
>>> Signed-off-by: Govindraj.R<govindraj.raja@xxxxxx>
>>> ---
>>>   arch/arm/mach-omap2/omap_l3_noc.c |    1 +
>>>   1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-omap2/omap_l3_noc.c
>>> b/arch/arm/mach-omap2/omap_l3_noc.c
>>> index c8b1bef..c2cc196 100644
>>> --- a/arch/arm/mach-omap2/omap_l3_noc.c
>>> +++ b/arch/arm/mach-omap2/omap_l3_noc.c
>>> @@ -26,6 +26,7 @@
>>>   #include<linux/interrupt.h>
>>>   #include<linux/kernel.h>
>>>   #include<linux/slab.h>
>>> +#include<linux/module.h>
>>
>> That one is already fixed by Axel Lin, and already pulled by Tony.
>>
>> http://www.spinics.net/lists/linux-omap/msg59847.html
>>
>> This is the missing semi-colon that still need to be fixed.
>>
> Opps. I missed that one while acking the patch.
> Indeed the semi-colon one was agreed to be the left over
> in the last patch discussion.

Sorry, my bad sent the wrong patch here's the right one.[1]

--
Thanks,
Govindraj.R

[1]:

>From 9d244c0dea4de10ab9052fc1fe7bde8846ad389e Mon Sep 17 00:00:00 2001
From: Govindraj.R <govindraj.raja@xxxxxx>
Date: Tue, 8 Nov 2011 16:57:22 +0530
Subject: [PATCH] OMAP2+: Fix Compilation error on current mainline

Fix below compilation failure on mainline kernel commit id
1ea6b8f48918282bdca0b32a34095504ee65bab5

arch/arm/mach-omap2/omap_l3_noc.c:240: error: expected ',' or ';'
before 'MODULE_DEVICE_TABLE'

Signed-off-by: Govindraj.R <govindraj.raja@xxxxxx>
Acked-by: Santosh Shilimkar <santosh.shilimkar@xxxxxx>
---
 arch/arm/mach-omap2/omap_l3_noc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/omap_l3_noc.c
b/arch/arm/mach-omap2/omap_l3_noc.c
index 6a66aa5..d15225f 100644
--- a/arch/arm/mach-omap2/omap_l3_noc.c
+++ b/arch/arm/mach-omap2/omap_l3_noc.c
@@ -237,7 +237,7 @@ static int __devexit omap4_l3_remove(struct
platform_device *pdev)
 static const struct of_device_id l3_noc_match[] = {
 	{.compatible = "ti,omap4-l3-noc", },
 	{},
-}
+};
 MODULE_DEVICE_TABLE(of, l3_noc_match);
 #else
 #define l3_noc_match NULL
-- 
1.7.4.1
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux