Re: [PATCH] ARM: omap4: prm: Fix up swapped offset macros

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




   /* OMAP4 specific register offsets */
   #define OMAP4_RM_RSTCTRL				0x0000
-#define OMAP4_RM_RSTTIME				0x0004
-#define OMAP4_RM_RSTST				0x0008
+#define OMAP4_RM_RSTST				0x0004
+#define OMAP4_RM_RSTTIME				0x0008
   #define OMAP4_PM_PWSTCTRL				0x0000
   #define OMAP4_PM_PWSTST				0x0004

In fact these defines were already defined correctly later (with a slightly different name):

/* PRM.DEVICE_PRM register offsets */

[...]

#define OMAP4_PRM_RSTST_OFFSET		0x0004
#define OMAP4430_PRM_RSTST		OMAP44XX_PRM_REGADDR(OMAP4430_PRM_DEVICE_INST, 0x0004)
#define OMAP4_PRM_RSTTIME_OFFSET	0x0008
#define OMAP4430_PRM_RSTTIME		OMAP44XX_PRM_REGADDR(OMAP4430_PRM_DEVICE_INST, 0x0008)


I don't know where these defines are used, but we'd better use the existing ones.

Yes, it looks like it makes sense to completely get rid of these and
instead use the auto-generated ones.
I see there are these multiple defines for omap3 too, maybe its best to
get rid of them for omap3 too?


Benoit

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux