> -----Original Message-----
> From: Hiremath, Vaibhav
> Sent: Monday, November 07, 2011 8:28 PM
> To: linux-omap@xxxxxxxxxxxxxxx
> Cc: tony@xxxxxxxxxxx; Hiremath, Vaibhav
> Subject: [PATCH] arm:omap:serial:cleanup: use module rev instead of
> cpu_is_xxxx
>
> For OMAP3 uarts (module rev >= 0x52) and all successor devices
> (omap4, TI81xx, AM33xx, etc...) empty fifo read errata is applicable,
> so we can get rid of cpu_is_xxxx check and simply check for module rev
> here.
>
Ideally, isn't module errata information should come
from HWMOD data? I think it should...does it make sense?
Thanks,
Vaibhav
> Signed-off-by: Vaibhav Hiremath <hvaibhav@xxxxxx>
> ---
> NOTE: This patch has been tested on OMAP3EVM, and I expect to work on all
> OMAP3
> family of devices (including TI816x, TI814x, AM335x, etc...).
> but I am quite not sure about OMAP2 device, can anybody comment/test?
>
> arch/arm/mach-omap2/serial.c | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/serial.c b/arch/arm/mach-omap2/serial.c
> index 9992dbf..ac274dc 100644
> --- a/arch/arm/mach-omap2/serial.c
> +++ b/arch/arm/mach-omap2/serial.c
> @@ -740,16 +740,16 @@ void __init omap_serial_init_port(struct
> omap_board_data *bdata)
> p->private_data = uart;
>
> /*
> - * omap44xx, ti816x: Never read empty UART fifo
> + * all >omap3 family of devices: Never read empty UART fifo
> * omap3xxx: Never read empty UART fifo on UARTs
> * with IP rev >=0x52
> */
> uart->regshift = p->regshift;
> uart->membase = p->membase;
> - if (cpu_is_omap44xx() || cpu_is_ti816x())
> - uart->errata |= UART_ERRATA_FIFO_FULL_ABORT;
> - else if ((serial_read_reg(uart, UART_OMAP_MVER) & 0xFF)
> - >= UART_OMAP_NO_EMPTY_FIFO_READ_IP_REV)
> + if (cpu_is_omap34xx() && (serial_read_reg(uart, UART_OMAP_MVER) &
> 0xFF)
> + < UART_OMAP_NO_EMPTY_FIFO_READ_IP_REV)
> + uart->errata &= ~UART_ERRATA_FIFO_FULL_ABORT;
> + else
> uart->errata |= UART_ERRATA_FIFO_FULL_ABORT;
>
> if (uart->errata & UART_ERRATA_FIFO_FULL_ABORT) {
> --
> 1.7.0.4
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
