On Fri, Nov 4, 2011 at 10:27 PM, Kevin Hilman <khilman@xxxxxx> wrote: > Tarun Kanti DebBarma <tarun.kanti@xxxxxx> writes: > >> From: Nishanth Menon <nm@xxxxxx> >> >> GPIO debounce registers need to be saved and restored for proper functioning >> of driver. > > OK. > >> To save the registers, we cannot cut the clock before the save, >> hence move the clk disable after the save. > > This patch doesn't move any clk disable. > > I suspect you made some changes to the original patch from Nishanth. > Please note that in the changelog. This is typically done by adding > something like: > > [my@xxxxxxxxxx: describe changes made] > > just before your signoff. Yes, quite a bit of changes happened which not captured in the description. The save context has been moved from *_runtime_suspend() to _set_gpio_debounce() as part of your comment in v6 to reduce overhead. Also, the clock disable is moved to *_prepare_for_idle(). I will add changelog to capture above changes. -- Tarun > > Kevin > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html