Omar Ramirez Luna <omar.ramirez@xxxxxx> writes: > Use runtime PM functionality interfaced with hwmod enable/idle > functions, to replace direct clock operations, reset and sysconfig > handling. > > Tidspbridge uses a macro removed with this patch, for now the value > is hardcoded to avoid breaking compilation. > > Signed-off-by: Omar Ramirez Luna <omar.ramirez@xxxxxx> Looks like a good cleanup. I agree with the comments from Myungjoo, and have a question below.. [...] > @@ -821,9 +820,7 @@ static irqreturn_t iommu_fault_handler(int irq, void *data) > if (!obj->refcount) > return IRQ_NONE; > > - clk_enable(obj->clk); > errs = iommu_report_fault(obj, &da); > - clk_disable(obj->clk); > if (errs == 0) > return IRQ_HANDLED; I'm not terribly familiar with this IOMMU code, but this one looks suspiciou because you're removing the clock calls but not replacing them with runtime PM get/put calls. I just want to make sure that's intentional. If so, you might want to add a comment about that to the changelog. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
