On Fri, Oct 28, 2011 at 22:33, Sascha Hauer wrote: > On Thu, Oct 27, 2011 at 02:48:11PM +0200, Linus Walleij wrote: >> +/* >> + * Request or free resources, currently just regulators. >> + * >> + * The SMSC911x has two power pins: vddvario and vdd33a, in designs where >> + * these are not always-on we need to request regulators to be turned on >> + * before we can try to access the device registers. >> + */ >> +static int smsc911x_request_free_resources(struct platform_device *pdev, >> + bool request) > > I had to look twice at this function name. First I thought "request the > free resources?", which other resources would you request if not the > free ones? I think it would be nicer to have two functions instead. > Just my 2 cents. i'll add my 2 cents and we'll almost have a nickle. maybe i'm dense, but i had to look (more than) twice at both funcs before i could get my head around what was happening. no, it's not complicated, but it is unusual in the kernel world. either that or i haven't read enough kernel code to consider this a common paradigm. hopefully it's the former ;). -mike -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
