Re: [RFT/PATCH 7/7] arm: omap: smartreflex: micro-optimization for sanity check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 11-10-2011 16:19, Felipe Balbi wrote:

On 10-10-2011 16:26, Felipe Balbi wrote:

val&&   (val != 1) == val>   1

Signed-off-by: Felipe Balbi<balbi@xxxxxx>
---
  arch/arm/mach-omap2/smartreflex.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c
index 7bdabfa..4b0d6a8 100644
--- a/arch/arm/mach-omap2/smartreflex.c
+++ b/arch/arm/mach-omap2/smartreflex.c
@@ -866,7 +866,7 @@ static int omap_sr_autocomp_store(void *data, u64 val)
  	}

  	/* Sanity check */
-	if (val&&   (val != 1)) {
+	if (val>   1) {
  		pr_warning("%s: Invalid argument %lld\n", __func__, val);

    The format specified should be "%llu"?

and what does that have to do with $SUBJECT ??

   Well, nothing. Just an idea for another patch I guess.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux