Santosh Shilimkar <santosh.shilimkar@xxxxxx> writes: > On Monday 10 October 2011 11:31 PM, Kevin Hilman wrote: >> Hi Santosh, >> >> Santosh Shilimkar <santosh.shilimkar@xxxxxx> writes: >> >>> The series adds OMAP4 MPUSS (MPU SubSystem) power management support for >>> suspend (S2R), CPU hotplug and CPUidle. >> >> There are a few more compile errors when doing OMAP1-only builds. >> You'll need a way to eliminate the secure calls for OMAP1. >> >> This series causes a couple build errors when doing OMAP1-only builds >> (I used omap1_defconfig): >> > OK. Thanks for catching it. > >> First: >> >> /work/kernel/omap/pm/arch/arm/plat-omap/common.c:24:30: fatal error: mach/omap-secure.h: No such file or directory >> >> And trying creating a dummy header to see if it would continue to build gives: >> >> /work/kernel/omap/pm/arch/arm/plat-omap/common.c: In function 'omap_reserve': >> /work/kernel/omap/pm/arch/arm/plat-omap/common.c:70:2: error: implicit declaration of function 'omap_secure_ram_reserve_memblock' >> make[2]: *** [arch/arm/plat-omap/common.o] Error 1 >> make[1]: *** [arch/arm/plat-omap] Error 2 >> > For OMAP1 build, omap_secure_ram_reserve_memblock() definition is > needed since common.c is built for OMAP1 as well. > The trivial change in the end of this email fixes the omap1 build. Looks good. > Have folded that change in original patch and updated the OMAP4 > PM branch - for_3_2/omap4-mpuss-pm_2 Thanks. > Regards > Santosh > P.S : Even with this fix, omap1_defconfig build breaks because of USB. > I removed USB from build to check rest of the build and it was > fine then. OK. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
