Hi Paul,
On 10/6/2011 20:40, Paul Walmsley wrote:
On Fri, 16 Sep 2011, Jon Hunter wrote:
From: Jon Hunter<jon-hunter@xxxxxx>
The OMAP36xx and OMAP4xxx DPLLs have a different internal reference
clock frequency (fint) operating range than OMAP3430. Update the
dpll_test_fint() function to check for the correct frequency ranges
for OMAP36xx and OMAP4xxx.
For OMAP36xx and OMAP4xxx devices, DPLLs fint range is 0.5MHz to
2.5MHz for j-type DPLLs and otherwise it is 32KHz to 52MHz for all
other DPLLs.
Signed-off-by: Jon Hunter<jon-hunter@xxxxxx>
This looks okay to me for now - queued for 3.2. Ideally we would move the
Fint DPLL data to the struct dpll_data, but this would be a fairly
significant undertaking, since we don't have a clean way to use different
dpll_data for different OMAP3 variants. Something good to keep in mind
for the common clock conversion.
You know at first I was thinking about adding this to the dpll_data
struct, but then I thought these ranges only change for a couple dplls
and so adding a few more members to each dpll struct was bloating the
struct and making this a massive change. So I went the other path and
just added a couple defines to minimise the changes. However, we could
definitely do that if it is preferred and if with next-gen devices (such
as omap5) more dplls have different ranges then this would make more
sense too.
Cheers
Jon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
