Govindraj <govindraj.ti@xxxxxxxxx> writes: > Hi Kevin, > > Thanks for the review, > > > On Wed, Oct 5, 2011 at 3:12 AM, Kevin Hilman <khilman@xxxxxx> wrote: >> "Govindraj.R" <govindraj.raja@xxxxxx> writes: >> >>> We had been using traditional 8250 driver as uart console driver >>> prior to omap-serial driver. Since we have omap-serial driver >>> in mainline kernel for some time now it has been used as default >>> uart console driver on omap2+ platforms. Remove 8250 support for >>> omap-uarts. >> >> Nice to see the this disappearing. >> >>> Serial_in and serial_out override for 8250 serial driver is also >>> removed. > >>> Empty fifo read fix is already taken care with omap-serial >>> driver with data ready bit check from LSR reg before reading RX fifo. >> >> As stated in the previous review. Patches that move code/features >> should have the removal and the add-back in the same patch. Doing so >> makes it easy for reviewers to see whether it was simply moved, or if it >> was modified when it was moved, etc. >> > > Empty fifo read is already taken care in omap-serial.c and is part of > mainline code. Nothing to add to omap-serial.c OK, good. I guess I missed the 'already' part in your changelog. >>> Also waiting for THRE(transmit hold reg empty) is done with wait_for_xmitr >>> in omap-serial driver. >> >> Again, remove it here in the patch that adds that support (the errata >> patch I guess.) >> > > The errata patch ( [PATCH v6 11/16] ) moves only mdr_errata and force_idle > from serial.c to omap-serial.c. > > Already handled stuffs and things that already exists with omap-serial.c > are removed here. OK. >>> Remove headers that were necessary to support 8250 support >>> and remove all config bindings done to keep 8250 backward compatibility >>> while adding omap-serial driver. Remove omap_uart_reset needed for >>> 8250 autoconf. >>> >>> Signed-off-by: Govindraj.R <govindraj.raja@xxxxxx> >> >> So basically, this patch should only remove the legacy 8250 support (as >> the subject says) and everything else should be done in the other >> relevant patches. >> > > Yes removes only the 8250 code. serial_in/serial_out were read/write overrides > part of 8250 code. > > serial_in/serial_out had these checks for empty fifo read and wait for tx > which is already handled with omap-serial.c. OK, thanks for the clarification. The changelog could've been a bit more specific for readers not intimately familiar with the driver. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
