On Wed, Sep 28, 2011 at 12:02 AM, Paul Walmsley <paul@xxxxxxxxx> wrote: > Hi, > > On Fri, 16 Sep 2011, Jon Hunter wrote: > >> From: Mike Turquette <mturquette@xxxxxx> >> >> omap3_noncore_dpll_set_rate uses omap2_dpll_round_rate explicitly. Instead >> use the struct clk pointer's round_rate function to allow for DPLL's with >> special needs. >> >> Also the rounded rate can differ from target rate, so to better reflect >> reality set clk->rate equal to the rounded rate when setting DPLL frequency. >> This avoids issues where the DPLL frequency is slightly different than what >> debugfs clock tree reports using the old target rate. >> >> An example of both of these needs is DPLL_ABE on OMAP4 which can have a 4x >> multiplier on top of the usual MN dividers depending on register settings. >> This requires a special round_rate function that might yield a rate >> different from the initial target. >> >> Signed-off-by: Mike Turquette <mturquette@xxxxxx> >> Signed-off-by: Jon Hunter <jon-hunter@xxxxxx> > > The two separate changes in this patch have been separated out into two > patches - both included below. Please let me know if you have any > comments; otherwise, I'll queue for 3.2. The split patches look good to me. I have another patch which does a similar thing (converts omap2_get_dpll_rate use to clk->recalc) which fixes yet more bugs that plague DPLL_ABE. Will send across shortly; hopefully can make it into 3.2? Regards, Mike -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html