On Tue, Sep 27, 2011 at 03:42:52PM +0530, Rajendra Nayak wrote: > Look up the regulator for a given consumer from device tree, during > a regulator_get(). If not found fallback and lookup through > the regulator_map_list instead. As with the fixed voltage regulator patch just use the code along with adding it, no need to split it just makes it harder to review. > + if (dev->of_node) { > + node = of_get_regulator(dev, id); > + if (!node) > + goto retry; /* fallback and chk regulator_map_list */ > + list_for_each_entry(rdev, ®ulator_list, list) > + if (node == rdev->node) > + goto found; > + } > +retry: retry is a confusing name for the target, we don't ever actually retry using it. Given the simplicity of the code I'd be inclined to just intert the if (!node) check. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html