On Tue, Sep 13, 2011 at 1:26 AM, Per Forlin <per.forlin@xxxxxxxxxx> wrote: > On 1 September 2011 21:05, Venkatraman S <svenkatr@xxxxxx> wrote: >> Reuse omap_hsmmc_dma_cleanup even for normal dma teardown in >> omap_hsmmc_dma_cb. Consolidate multiple points of dma unmap into a >> single location in post_req function, to prevent double unmapping. > It's optional to use pre_req() and post_req(). The SDIO framework > doesn't utilise these hooks. For instance this wont work together with > SDIO-wlan on the pandaboard. > If pre_req() has been issued it's fine to defer dma_unmap() until > post_req(). If pre_req() is not called the driver should call > dma_unmap() directly. > In that case, can the actual 'request' function just call pre_req and post_req (at the beginning and at the end), if host_cookie is not set ? -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html