Hi Sanjeev, On Wed, 14 Sep 2011, Premi, Sanjeev wrote: > > -----Original Message----- > > From: Paul Walmsley [mailto:paul@xxxxxxxxx] > > > > Am looking at your commit 4cac6018, which touches > > arch/arm/mach-omap2/id.c. That commit implements SoC > > detection for the > > 3505 in a different way than the implementations for other > > OMAP2+ devices: > > it doesn't enumerate the possible TAP revisions for OMAP3505. > > The TRM > > In the function omap3_check_revision(), the revision is being > extracted from the TAP register for AM3505/AM3517 devices thru > same code used for OMAP34xx registers. > > OR, Am I missing something? Sorry, my original message was not clear. In omap3_check_revision(), it does this for 3517/3505: omap_revision = OMAP3505_REV(rev); but for other chips, it does something like this: omap_revision = OMAP3430_REV_ES3_1_2; The main point being that, with the latter, all of the possible values for omap_revision for OMAP3430 are known. But after I sent that message, I realized that some of the duplicate testing code in omap3_cpuinfo() did enumerate revisions for 3517/3505: ES1.0 and ES1.1. So I've used that instead in the patch series that I sent. If there are others beyond those two, please let us know... Thanks for the quick response. - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
