Hi Joerg, On Tue, Sep 13, 2011 at 1:10 PM, Roedel, Joerg <Joerg.Roedel@xxxxxxx> wrote: > Please split this patch into the core-change and patches for the > individual iommu-drivers and post this as a seperate patch-set. But we'll be breaking bisectibility this way, no ? > Intel IOMMU does not support arbitrary page-sizes, afaik. It does; besides the usual 4K it has "super page sizes" support of 2MB, 1GB, 512GB and 1TB. >> + pr_debug("map: iova 0x%lx pa 0x%lx size 0x%lx\n", iova, >> + (unsigned long)paddr, size); > > Please keep the debug-code in a seperate patch in your dev-tree. No need > for it to be merged upstream. It's actually useful sometimes to have those around - it's off by default, and can be enabled only when needed (CONFIG_DYNAMIC_DEBUG). But I don't mind removing them. Thanks, Ohad. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html