Hi, On Wed, Sep 7, 2011 at 5:25 PM, Tomi Valkeinen <tomi.valkeinen@xxxxxx> wrote: > Hi, > > On Tue, 2011-09-06 at 17:28 +0530, mythripk@xxxxxx wrote: >> From: Mythri P K <mythripk@xxxxxx> >> >> HDMI IP block is common between TI OMAP4 Procerssor and Netra processor although >> the Display subsytem is different.Also the IP block in future OMAP may differ >> from the one existing in OMAP4. Thus to reuse the code between these two >> processors , and maintain the multi omap build functionality in DSS. >> HDMI IP dependant code is seperated out from hdmi.c and moved to >> new library file hdmi_ti_4xxx_ip.c.From the DSS dependent HDMI code only the >> function pointer to functionality/features offered by HDMI is called. >> >> This patch series does the split and also renames hdmi_omap4_panel.c to >> hdmi_panel.c as that file has nothing specific to OMAP4 and can be reused for >> other OMAP family of processors as well. >> >> This patch series is based on Tomi's LO-DSS2 master branch. >> >> changes since >> v3:Handle the sparse error for set_pll_pwr function >> Move audio functions out of hdmi.c to ip file. >> rename hdmi_data to ip_data >> V2: Rename certain files/function to have standard format and handle scenario >> when hdmi is disabled. >> V1: Function pointer approach to call the HDMI IP functions from DSS HDMI > > I think there's still lots of cleanups/restructuring needed for HDMI, > but I'm willing to merge this patch set as it'll gives as a good > baseline to continue the work, and trying to do too much in one go would > just be difficult. > > However, there are a couple of changes I wish you can do first: > > - Remove refsel. You still have an enum and a field for it, even if it's > not used. > Instead fixed the bug in the same patch to use refsel to be set in the PLL_CFG2. > - Instead of creating include/video/ti_hdmi.h, create the file into > drivers/video/omap2/dss/. Let's keep this totally inside DSS2 for the > time being. Sure done. > > - You still haven't changed copy_hdmi_to_dss_timings() to take a pointer > instead of a value. It's been commented at least three times already. As > similar things seem to happen quite often for you, if you have trouble > remembering all the required changes, please write the received comments > down to, say, a piece of paper, and cross them over when you've actually > made the change. It's a waste of reviewers time to review and comment > the same problems again and again. > Point taken. Thanks for your review. Fixed this. > - Go though the commit subjects and descriptions. I see the same typoes > that I've also already commented about, and I see new ones also. > Description on patch 10 is almost gibberish. Added more details to most of patches in series. Posting the patch. Mythri. > > Tomi > > > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
