Mike, I have a minor comment below. On Thu, Jun 30, 2011 at 2:25 AM, Mike Turquette <mturquette@xxxxxx> wrote: > The Adaptive Body-Bias ldo can be set to bypass or Forward Body-Bias > after voltage scaling is performed. > > This patch implements the Adaptive Body-Bias ldo initialization routine > and the transition sequence which is needed after a vc_bypass or > vp_forceupdate sequence completes. > > Signed-off-by: Mike Turquette <mturquette@xxxxxx> > --- ... > diff --git a/arch/arm/mach-omap2/abb.c b/arch/arm/mach-omap2/abb.c > new file mode 100644 > index 0000000..b8b6b4b ... > +/* > + * omap_abb_disable - disable ABB ldo on a particular voltage domain > + * > + * @voltdm - pointer to particular voltage domain > + * > + * Included for completeness. Not currently used but will be needed in the > + * future if ABB is converted to a loadable module. > + */ > +void omap_abb_disable(struct voltagedomain *voltdm) > +{ > + struct omap_abb_instance *abb = voltdm->abb; > + > + if (!abb->enabled) > + return; > + > + abb->enabled = false; > + > + voltdm->rmw(abb->common->sr2en_mask, > + (0 << __ffs(abb->common->sr2en_mask)), (0 << x) can be replaced with 0. > + abb->setup_offs); > +} > + ... Regards, Jean -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html