Re: [PATCH 2/7] arm/dts: OMAP3: Add mpu and iva nodes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/5/2011 7:46 PM, Mitch Bradley wrote:
On 9/5/2011 7:23 AM, Arnd Bergmann wrote:
On Monday 05 September 2011, Cousson, Benoit wrote:
Yeah, I saw that in the "cpus" node documentation. My point here is that
I do need to represent the MPU subsystem that will contain the cpus. And
thus the Cortex is inside the MPU subsystem.


The device tree hierarchy does not represent "containment", but rather
addressing from the standpoint of a program running on a CPU.

  From that viewpoint, it might be better to have a phandle reference to
the mpu in each CPU node.

So in that case, I'd rather use a scheme similar to a shared cache between CPUs:

cpus {
	cpu@0 {
		compatible = "arm,cortex-a8";
		subsystem = <&mpu>

		mpu: arm_mpu {
			compatible = "ti,omap3-mpu";
			hwmods = "mpu";
	};
};

And for an OMAP4 SMP system:

cpus {
	cpu@0 {
		compatible = "arm,cortex-a9";
		subsystem = <&mpu>

		mpu: arm_mpu {
			compatible = "ti,omap4-mpu";
			hwmods = "mpu";
	};

	cpu@1 {
		compatible = "arm,cortex-a9";
		subsystem = <&mpu>
	};
};

Ideally the interrupt-controller/GIC should probably be inside that MPU node, isn't it?

Thanks,
Benoit




I can potentially keep the CPUs inside the cpus node, and just represent
the mpu node inside the soc, with potentially some phandle to the real
cpu nodes.

Something like that:

cpus {
          cpu0: cpu@0 {
                          compatible = "arm,cortex-a8";
          };
};

[...]

soc {
          compatible = "ti,omap-infra";
          mpu {
                  compatible = "ti,omap3-mpu";
                  hwmods = "mpu";
                  cpu@0 {
                          phandle =<&cpu0>;
                          [...]
                  };
          };
};

Yes, that looks good. I wouldn't name the attribute "phandle" if I could
think of anything better (which I can't at the moment).

	Arnd
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@xxxxxxxxxxxxxxxx
https://lists.ozlabs.org/listinfo/devicetree-discuss


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux