Re: [PATCH 3/3] trace points: power: remove 'cpu_id' from trace_cpu_idle

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, Sep 2, 2011 at 3:26 PM, Jean Pihet <jean.pihet@xxxxxxxxxxxxxx> wrote:
>> It was known that cpu_id is always the current cpu with current
>> implementation when this got introduced.
>> But the perf events API must not change back and forth for userspace
>> compatibility. Therefore the cpu_id was added in case
>> that future implementations want to pass info where the current cpu
>> is not the cpu which is sent to the sleep state.
> Agree. Let's keep the cpu_id field.

OK, let's keep it.

How about removing it in clock_enalbe/clock_disable/power_domain_target
as did in [1/3] and [2/3]?  I don't see any usefulness of 'cpu_id' in the tree
trace points.


thanks,
-- 
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux