Hi, On Thu, Sep 1, 2011 at 1:44 PM, Tomi Valkeinen <tomi.valkeinen@xxxxxx> wrote: > On Mon, 2011-08-29 at 11:44 +0530, mythripk@xxxxxx wrote: >> From: Mythri P K <mythripk@xxxxxx> >> >> Define new HDMI timings structure to replace the OMAP DSS timing strucutre in >> hdmi.c to have the HDMI include defintion out of DSS. > > structure and definition typoed. And the point is not to remove hdmi > stuff from dss, but dss stuff from hdmi. The generic hdmi driver cannot > use omap dss specific stuff. > >> Signed-off-by: Mythri P K <mythripk@xxxxxx> >> --- >> drivers/video/omap2/dss/hdmi.c | 22 +++++++++++++++++++--- >> drivers/video/omap2/dss/hdmi.h | 15 ++++++++++++++- >> 2 files changed, 33 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c >> index 084a47e..ba1ad06 100644 >> --- a/drivers/video/omap2/dss/hdmi.c >> +++ b/drivers/video/omap2/dss/hdmi.c >> @@ -537,6 +537,20 @@ static int read_edid(struct hdmi_ip_data *ip_data, u8 *pedid, u16 max_length) >> return 0; >> } >> >> +static void copy_hdmi_to_dss_timings(struct hdmi_video_timings hdmi_timings, >> + struct omap_video_timings *timings) > > Pass hdmi_timings as a const pointer. > Ok. > Tomi > > > Thanks and regards, Mythri -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html