On Tue, Aug 30, 2011 at 2:17 AM, Kevin Hilman <khilman@xxxxxx> wrote: > Kevin Hilman <khilman@xxxxxx> writes: > >> Keshava Munegowda <keshava_mgowda@xxxxxx> writes: >> >>> From: Keshava Munegowda <Keshava_mgowda@xxxxxx> >>> >>> The usbhs core driver does not enable/disable the intefrace and >>> fucntional clocks; These clocks are handled by hwmod and runtime pm, >>> hence insted of the clock enable/disable, the runtime pm APIS are >>> used. however,the port clocks are handled by the usbhs core. >>> >>> Signed-off-by: Keshava Munegowda <keshava_mgowda@xxxxxx> >> >> General comment: all usage of pm_runtime_put_sync() can likely be >> replaced by the asynchronous versions. I don't currently see why the >> synchronous verions are needed here. >> >> Other than that, the runtime PM parts of this look OK to me. After >> changing to asynchonous puts, feel free to add: >> >> Reviewed-by: Kevin Hilman <khilman@xxxxxx> > > oops, this should've been in response to your v8 version. > > Kevin > >> >> Also, after a quick glance, it looks like this version of the series >> addresses the problems seen by Jassi Brar with the TLL reset[1]. Please >> confirm. >> >> Speaking of which, it's helpful to Cc folks who have had comments on >> previous versions of your series so they are sure they're previous >> issues are addressed. I've Cc'd Jassi Brar. >> >> Thanks, >> >> Kevin >> >> [1] http://marc.info/?l=linux-omap&m=130921260703865&w=2 > Thanks for review; yes, its reworks of complete runtime pm of usbhs as suggested by Jassi Brar. balbi, sameo this patch series available at the branch kmg-usbhs-pm of code repository : git://gitorious.org/~kmg/mirrors/kmg-usbhs-pm.git Regards Keshava -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
