[...] > > void omap2_gpio_prepare_for_idle(int off_mode) > > { > > - int i, c = 0; > > - int min = 0; > > - > > - if (cpu_is_omap34xx()) > > - min = 1; > > + int c = 0; > > + struct gpio_bank *bank; > > > > - for (i = min; i< gpio_bank_count; i++) { > > - struct gpio_bank *bank =&gpio_bank[i]; > > + list_for_each_entry(bank,&omap_gpio_list, node) { > > u32 l1 = 0, l2 = 0; > > int j; > > > > + /* TODO: Do not use cpu_is_omap34xx */ > > Is this addressed in subsequent patches ? Yes. -- Tarun > > > + if ((cpu_is_omap34xx())&& (bank->id == 0)) > > + continue; > > + > > Rest of the changes looks good to me. > After you answer above, you can add my, > Reviewed-by: Santosh Shilimkar <santosh.shilimkar@xxxxxx> > > Regards > Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html