Hi, On Mon, Aug 29, 2011 at 11:01:54AM +0530, Gupta, Ajay Kumar wrote: > > > diff --git a/drivers/usb/musb/musb_core.c > > > b/drivers/usb/musb/musb_core.c index 20a2873..07f3faf 100644 > > > --- a/drivers/usb/musb/musb_core.c > > > +++ b/drivers/usb/musb/musb_core.c > > > @@ -1014,7 +1014,9 @@ static void musb_shutdown(struct > > platform_device *pdev) > > > || defined(CONFIG_USB_MUSB_OMAP2PLUS) \ > > > || defined(CONFIG_USB_MUSB_OMAP2PLUS_MODULE) \ > > > || defined(CONFIG_USB_MUSB_AM35X) \ > > > - || defined(CONFIG_USB_MUSB_AM35X_MODULE) > > > + || defined(CONFIG_USB_MUSB_AM35X_MODULE) \ > > > + || defined(CONFIG_USB_MUSB_TI81XX) \ > > > + || defined(CONFIG_USB_MUSB_TI81XX_MODULE) > > > > we really need to find a better way to handle this :-( > > How about passing the mode info from musb_config (musb->config->fifo_mode), > same way as musb->config->fifo_cfg not sure... Ideally we wouldn't really need those fifo tables, but I'm still thinking how to properly do that. > Infact I think, we can kill musb->config->fifo_cfg and have only > musb->config->mode as in this way all the fifo tables will be at one > place and should help in maintenance. The idea of musb->config->fifo_cfg was to allow boards to pass their optimal fifo table. If a certain product, knows it will only support mass storage, why not letting them enable only those needed endpoints in an optimized way (with double buffering, bulk combine/split, etc). > > > diff --git a/drivers/usb/musb/ti81xx.c b/drivers/usb/musb/ti81xx.c > > new > > > file mode 100644 index 0000000..f95774e > > > --- /dev/null > > > +++ b/drivers/usb/musb/ti81xx.c > > > > I still think this should be part of am35x.c It really look like they > > are very similar. > > Wrapper registers are different but I will see on this and provide you details > On how the merged file would look like. I am afraid that we may have to use > Either #ifdef or cpu_is_xxx(). we can use platform_device_id to cope with the differences :-) See how I'm using it on dwc3 driver (Greg's usb-next branch). -- balbi
Attachment:
signature.asc
Description: Digital signature
