Hi Kevin, Sorry for bit late reply, I've been on holiday during last 3 weeks. On Sat, 2011-08-06 at 01:37 +0200, Hilman, Kevin wrote: > Tero Kristo <t-kristo@xxxxxx> writes: > > > All voltagedomains that have support for vc and vp are now automatically > > registered with SMPS regulator driver. Voltage.c builds a platform device > > structure for this purpose during late init. > > > > Signed-off-by: Tero Kristo <t-kristo@xxxxxx> > > With the creation of this "dummy" platform device, I'm a bit confused > about how is the mapping from device to regulator meant to work here. > > e.g., for MPU DVFS, if I want to also scale voltage in the CPUfreq > driver, I would do something like > > dev = omap2_get_mpuss_device() > > and then want to somehow get the regulator associated with the MPU > device so I can do a regulator_set_voltage(). What would I use for the > id argument of regulator_get()? Hmm right, I haven't been thinking about this part in too much detail. However, the regulator names are built in following way: - take voltdm name (e.g. mpu_iva) - add "VDD_" in the beginning - capitalize whole thing (results in VDD_MPU_IVA) > What's missing (at least in my mind) is the mapping of devices to > regulators. True, should I think of something for this? > > Specifically, this part doesn't seem right: > > > + supply->supply = "vcc"; > > + supply->dev_name = voltdm->name; > > becase voltdm->name is not a device name. > > Kevin Texas Instruments Oy, Tekniikantie 12, 02150 Espoo. Y-tunnus: 0115040-6. Kotipaikka: Helsinki -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html