Hi, On Wednesday 24 August 2011 13:21:27 Ravi, Deepthy wrote: > On Wed, Aug 24, 2011 at 4:47 PM, Laurent Pinchart wrote: > > On Friday 19 August 2011 15:48:45 Deepthy Ravi wrote: > >> From: Vaibhav Hiremath <hvaibhav@xxxxxx> > >> > >> Fix the build break caused when CONFIG_MEDIA_CONTROLLER > >> option is disabled and if any sensor driver has to be used > >> between MC and non MC framework compatible devices. > >> > >> For example,if tvp514x video decoder driver migrated to > >> MC framework is being built without CONFIG_MEDIA_CONTROLLER > >> option enabled, the following error messages will result. > >> drivers/built-in.o: In function `tvp514x_remove': > >> drivers/media/video/tvp514x.c:1285: undefined reference to > >> `media_entity_cleanup' > >> drivers/built-in.o: In function `tvp514x_probe': > >> drivers/media/video/tvp514x.c:1237: undefined reference to > >> `media_entity_init' > > > > If the tvp514x is migrated to the MC framework, its Kconfig option should > > depend on MEDIA_CONTROLLER. > > The same TVP514x driver is being used for both MC and non MC compatible > devices, for example OMAP3 and AM35x. So if it is made dependent on MEDIA > CONTROLLER, we cannot enable the driver for MC independent devices. Then you should use conditional compilation in the tvp514x driver itself. Or better, port the AM35x driver to the MC API. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
