Re: [PATCH v5 05/22] gpio/omap: handle save/restore ctx in GPIO driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday 04 August 2011 04:34 PM, Tarun Kanti DebBarma wrote:
From: Charulatha V<charu@xxxxxx>

Modify omap_gpio_prepare_for_idle()&  omap_gpio_resume_after_idle() functions
to handle save context&  restore context respectively in the OMAP GPIO driver
itself instead of calling these functions from pm specific files.
For this, in gpio_prepare_for_idle(), call *_get_context_loss_count() and in
gpio_resume_after_idle() call it again. If the count is different, do restore
context. The workaround_enabled flag is no more required and is removed.

Signed-off-by: Charulatha V<charu@xxxxxx>
Signed-off-by: Tarun Kanti DebBarma<tarun.kanti@xxxxxx>
---

"ctx" ?
Please change it to 'context' is subject and rest of the code.


  arch/arm/mach-omap2/gpio.c             |   12 +++
  arch/arm/mach-omap2/pm34xx.c           |   14 ----
  arch/arm/plat-omap/include/plat/gpio.h |    5 +-
  drivers/gpio/gpio-omap.c               |  131 ++++++++++++++------------------
  4 files changed, 73 insertions(+), 89 deletions(-)

diff --git a/arch/arm/mach-omap2/gpio.c b/arch/arm/mach-omap2/gpio.c
index 95195a8..2e65377 100644
--- a/arch/arm/mach-omap2/gpio.c
+++ b/arch/arm/mach-omap2/gpio.c
@@ -23,6 +23,7 @@

  #include<plat/omap_hwmod.h>
  #include<plat/omap_device.h>
+#include<plat/omap-pm.h>

  #include "powerdomain.h"

@@ -34,6 +35,16 @@ static struct omap_device_pm_latency omap_gpio_latency[] = {
  	},
  };

+#ifdef CONFIG_PM
+static int omap_gpio_get_context_loss(struct device *dev)
+{
+	return omap_pm_get_dev_context_loss_count(dev);
+}
Do you really need this wrapper. Use the funtion directly instead.

Rest looks fine to me
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux